jdaugherty commented on code in PR #15654:
URL: https://github.com/apache/grails-core/pull/15654#discussion_r3358555374
##########
grails-data-hibernate5/grails-plugin/src/test/groovy/grails/test/mixin/hibernate/HibernateSpecSpec.groovy:
##########
@@ -26,6 +26,7 @@ import grails.test.hibernate.HibernateSpec
*/
class HibernateSpecSpec extends HibernateSpec {
+
Review Comment:
I removed the blank line.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/QueryEventsSpec.groovy:
##########
@@ -33,39 +31,42 @@ import
org.grails.datastore.mapping.query.event.PreQueryEvent
/**
* Tests for query events.
*/
-// TODO: the application context is null on hibernate tck tests, so this test
errors on the add of the application listener
-@IgnoreIf({ System.getProperty('hibernate5.gorm.suite') ||
System.getProperty('hibernate6.gorm.suite') ||
System.getProperty('mongodb.gorm.suite') })
class QueryEventsSpec extends GrailsDataTckSpec {
SpecQueryEventListener listener
+ boolean contextAvailable = false
Review Comment:
Documentation added.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/SessionCreationEventSpec.groovy:
##########
@@ -31,20 +29,22 @@ import
org.grails.datastore.mapping.core.SessionCreationEvent
/**
* Test case that session creation events are fired.
*/
-// TODO: the application context is null on hibernate tck tests, so this test
errors on the add of the application listener
-@IgnoreIf({ System.getProperty('hibernate5.gorm.suite') ||
System.getProperty('hibernate6.gorm.suite') ||
System.getProperty('mongodb.gorm.suite') })
class SessionCreationEventSpec extends GrailsDataTckSpec {
- @Override
+ Listener listener
+ boolean contextAvailable = false
Review Comment:
documentation added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
