jamesfredley commented on PR #15557: URL: https://github.com/apache/grails-core/pull/15557#issuecomment-4681403004
## Last-24h update: review burn-down + base alignment Description refreshed to match the current tree. Quick map of the commits since yesterday and the review threads each one closes out. ### Base alignment (via merge) - Merged latest `8.0.x`: Spring Boot **4.1.0** (#15727), Spock **2.4** (#15703), and the Gradle-managed version overrides (#15467). Target stack table updated accordingly (Spring Boot 4.1.0, Gradle 9.5.1). ### Review feedback addressed | Commit | Change | Closes | |---|---|---| | `2b83d84` | `LoggingTransformer` drives Groovy's own `LogASTTransformation` again instead of hand-building the `log` field | "retest this assumption, we want the `@Slf4j` path" / "ordering needs to run before the Slf4j AST" | | `37a9a4d` | Generated method nodes are created with `ClassNode.EMPTY_ARRAY` exceptions at the creation sites (`ServiceTransformation`, `ResourceTransform`); proxy fallback kept only for foreign null-exception nodes | "isn't the real fix to populate the exceptions at creation?" | | `7c1bae7` | Default view renderer fallbacks typed `Renderer<?>` (no erased-signature change) | "why isn't `?` allowed for `Object`?" on `DefaultViewRenderer` | | `dc37429` | `HibernateEntityTraitGeneratedSpec` checks the **declaring** class and fixes the `findWithSql`/`findAllWithSql` duplicate; `GroovyChangeLogSpec` drops env-dependent Liquibase stdout assertions | "this is a bug - `findAllWithSql` was changed to `findWithSql`" / "isn't this fixed now?" | | `c3eba98` | `DEFAULT_MESSAGES` kept immutable (`unmodifiableMap`) while preserving the GROOVY-12063 map-literal workaround; trait + `@Sortable` regressions documented inline | "maps are LinkedHashMaps - is this meant to be immutable?" + the two "this is a Groovy bug" threads | | `1eb7022` | Removed redundant comments (`dependencies.gradle`, GraphQL spec) and pointed the GSP skip at GROOVY-12041 | "remove the redundant comment" x3 | | `6f776b0` | CodeQL no longer autobuilds the Groovy sample apps | CI noise | ### Workaround removed (snapshot caught up) - **GROOVY-12062 is now Resolved/Fixed (5.0.7)** and verified on the consumed `5.0.7-SNAPSHOT`, so the `ControllerActionTransformer` `OptimizingStatementWriter.ClassNodeSkip` tag and the `boot4-disabled-integration-test-config.gradle` exclusions were dropped (`d3506cf`). The `indy=false` parameterized-action integration tests now run in both `indy` modes. This row is gone from the description. ### Still open (double-checked against the snapshot) The two JIRA-tracked workarounds remain because both tickets are still **Open** and still reproduce on `5.0.7-SNAPSHOT`: - **[GROOVY-12063](https://issues.apache.org/jira/browse/GROOVY-12063)** (open) - `ConstrainedProperty.DEFAULT_MESSAGES`. - **[GROOVY-11985](https://issues.apache.org/jira/browse/GROOVY-11985)** (open) - `Validateable` / `BeanPropertyAccessorFactory` reflection. [GROOVY-12041](https://issues.apache.org/jira/browse/GROOVY-12041) (open) also still affects the `g.taglib` STC path. The remaining no-clean-fix items @jdaugherty flagged (disabled undeclared-variable GSP specs, `@Sortable`+`@Entity` fixtures, the `TestTrait` bound, the `processVariableScopes` proxy fallback, and the `TransactionalTransformSpec` direct-invocation assertions) are now collected in the new **"Worked around without a clean fix"** table in the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
