The GitHub Actions job "Coverage" on 
grails-core.git/test/h7-functional-coverage has failed.
Run started by GitHub user jamesfredley (triggered by jamesfredley).

Head commit for run:
83e5ebd45448e05440d8dfd86ad36cadeac1172a / James Fredley 
<[email protected]>
Replace Hibernate 7 BOM substitution with shared TCK coverage

Reviewer feedback (jdaugherty -1, with matrei) objected to running the
general functional apps under Hibernate 7 via runtime dependency
substitution (redirectBomToH7): it breaks Gradle build caching, makes
dependency resolution hard to debug, hides which Hibernate line a coverage
report reflects, and requires threading -PhibernateVersion through every
tool and IDE.

Remove the substitution lane and cover the affected GORM behavior in the
shared TCK instead, which both grails-data-hibernate5 and
grails-data-hibernate7 already run via the GrailsDataTckManager ServiceLoader:

- gradle/functional-test-config.gradle: restore the base version, dropping
  the redirectBomToH7 machinery (h7IncompatibleProjects, grails-bom ->
  grails-hibernate7-bom redirect, grails-data-hibernate5 ->
  grails-data-hibernate7 substitution, hibernate-ehcache/jboss-transaction
  excludes, and the H7 BOM platform attachment).
- .github/workflows/gradle.yml: drop the hibernate-version matrix from the
  general functional job. The publish gate keeps requiring the existing
  hibernate7Functional job, so Hibernate 7 functional results still block
  publishing.
- grails-datamapping-tck FindWhereSpec/GormEnhancerSpec: add shared coverage
  for the version-agnostic finder behavior the PR fixed - findWhere and
  findAllWhere null matching (is null, not = null), findWhere single-result
  limiting, and getAll order preservation including convertible String ids
  and a null slot for a missing id.

All six new TCK tests pass on both Hibernate 5.6 and Hibernate 7.4.

Assisted-by: claude-code:claude-4.8-opus

Report URL: https://github.com/apache/grails-core/actions/runs/27652207197

With regards,
GitHub Actions via GitBox

Reply via email to