jamesfredley commented on PR #15557: URL: https://github.com/apache/grails-core/pull/15557#issuecomment-4748458783
Burned down the Groovy 5 workarounds against the current `5.0.7-SNAPSHOT` and merged the latest `8.0.x`. **Removed (now fixed upstream):** - **GROOVY-12091** (`ClassPropertyFetcherTests.TestTrait`) is Resolved/Fixed for Groovy 5.0.7. Restored the original `<F extends Serializable>` bound - the bounded generic trait-property setter is no longer left abstract in the implementer. Verified by `ClassPropertyFetcherTests.testClassPropertyFetcherWithTraitProperty` on the refreshed snapshot. This resolves @jdaugherty's "why are you removing serializable?" comment. **Checked, still required (kept):** - **GROOVY-12063** (`ConstrainedProperty.DEFAULT_MESSAGES` map literal) - still Open upstream. - **GROOVY-12041** (`GroovyPageTypeCheckingExtension` name-matching + `GspCompileStaticSpec` `@PendingFeatureIf`) - still Open upstream. - `Arguable` / `ComplexTyped` inline `withDelegate` - no upstream ticket. Re-tested on `5.0.7-SNAPSHOT`: reverting either trait to the parent-trait `withDelegate(closure, ...)` call still fails STC (`Cannot find matching method ...#withDelegate(Closure, Object)`). Groovy 5 STC does not resolve a parent trait's `static` method from a sub-trait body; this is distinct from the now-fixed GROOVY-11985 (static-override-via-`this`). I'll file a dedicated Groovy ticket so the inline can be dropped later. The PR description at the top has been updated to reflect the current state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
