codeconsole opened a new pull request, #15752:
URL: https://github.com/apache/grails-core/pull/15752
## Summary
On startup a full Grails application logs a bean-definition override for
`codecLookup`:
```
Overriding bean definition for bean 'codecLookup' with a different
definition:
replacing [...
factoryBeanName=org.grails.plugins.codecs.CodecsConfiguration;
factoryMethodName=codecLookup ...]
with [Generic bean: class=org.grails.plugins.codecs.DefaultCodecLookup ...]
```
`codecLookup` was registered **twice**, both producing a
`DefaultCodecLookup`:
- `CodecsConfiguration` — the `@Bean("codecLookup") @Primary`
auto-configuration bean (loaded in every production context, including
grails-testing-support and plain Spring Boot).
- `CodecsGrailsPlugin.doWithSpring` — a second registration that overrode
the auto-config one (the log). Because `doWithSpring` runs after
auto-configuration conditions are evaluated, the plugin bean always replaced
`CodecsConfiguration`'s — silently dropping its `@Primary` marker in the
process.
## Change
Remove the redundant `doWithSpring` registration so `CodecsConfiguration` is
the single definition. The resulting bean is unchanged — still a
`DefaultCodecLookup` under the name `codecLookup` — just registered once, with
no override.
Two contexts bootstrap from plugins rather than auto-configuration and
needed supporting changes:
- **`GrailsUnitTest.defineBeans(Object plugin)`** caught
`NoSuchFieldException`, but `clazz.getMethod('getDoWithSpring')` throws
`NoSuchMethodException`. A plugin whose `doWithSpring()` returns `null` (now
including `CodecsGrailsPlugin`) therefore crashed instead of being skipped.
Catch the correct exception.
- The legacy **`AbstractGrailsTagTests`** harnesses (grails-gsp and
grails-test-examples/gsp-layout) load plugins but never trigger
auto-configuration, so they register `codecLookup` directly.
## Verification
- Full suite green: 7754 unit + 1812 integration tests, 0 failures/errors.
- `aggregateViolations` / `codenarcMain` for the changed modules — clean.
- Booted the `gsp-sitemesh3` example app with `DefaultListableBeanFactory`
at INFO: the `Overriding bean definition for bean 'codecLookup'` line is gone,
and decoration/codec behavior is unchanged.
https://claude.ai/code/session_01WQtPU4SVwmiJyYiMMdVoNK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
