borinquenkid commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3453897376


##########
grails-data-hibernate5/core/src/main/groovy/org/grails/orm/hibernate/cfg/GrailsHibernateUtil.java:
##########
@@ -422,30 +420,6 @@ public static Object unwrapIfProxy(Object instance) {
         return proxyHandler.unwrap(instance);
     }
 
-    /**
-     * @deprecated Use {@link  
MultipleDataSourceSupport#getDefaultDataSource(PersistentEntity)} instead
-     */
-    @Deprecated
-    public static String getDefaultDataSource(PersistentEntity domainClass) {
-        return MultipleDataSourceSupport.getDefaultDataSource(domainClass);
-    }
-
-    /**
-     * @deprecated Use {@link  
MultipleDataSourceSupport#getDatasourceNames(PersistentEntity)} instead
-     */
-    @Deprecated
-    public static List<String> getDatasourceNames(PersistentEntity 
domainClass) {
-        return MultipleDataSourceSupport.getDatasourceNames(domainClass);
-    }
-
-    /**
-     * @deprecated Use {@link  
MultipleDataSourceSupport#getDefaultDataSource(PersistentEntity)} instead
-     */
-    @Deprecated
-    public static boolean usesDatasource(PersistentEntity domainClass, String 
dataSourceName) {
-        return MultipleDataSourceSupport.usesDatasource(domainClass, 
dataSourceName);
-    }
-

Review Comment:
   You're right — they were deleted without going through `forRemoval = true` 
first. Restored all three as `@Deprecated(forRemoval = true)` delegates to 
`MultipleDataSourceSupport`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to