matrei commented on code in PR #15743: URL: https://github.com/apache/grails-core/pull/15743#discussion_r3461874854
########## grails-data-mongodb/boot-plugin/src/test/groovy/org/grails/datastore/gorm/mongodb/boot/autoconfigure/MongoDbGormAutoConfigurationCloseSpec.groovy: ########## Review Comment: - What happens to feature method names if you remove the beginning "test "? I think it reads really good then as a statement of the expected behavior. - Use `def` for local variables where the type can be inferred. - Use single qoutes for strings. ########## grails-data-mongodb/core/src/test/groovy/org/grails/datastore/mapping/mongo/MongoDatastoreExternalClientSpec.groovy: ########## Review Comment: Same comments a for `MongoDbGormAutoConfigurationCloseSpec`. ########## grails-datastore-core/src/test/groovy/org/grails/datastore/mapping/core/connections/DefaultConnectionSourceSpec.groovy: ########## Review Comment: Same comments as in `MongoDbGormAutoConfigurationCloseSpec`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
