Copilot commented on code in PR #15829:
URL: https://github.com/apache/grails-core/pull/15829#discussion_r3524371884
##########
grails-data-hibernate7/dbmigration/build.gradle:
##########
@@ -64,9 +63,7 @@ dependencies {
implementation(project(':grails-shell-cli')) {
exclude group: 'org.slf4j', module: 'slf4j-simple'
- // TODO: the shell cli is exporting groovy 3, while this project is
expected to use groovy 4
- // this plugin needs split into commands & the plugin itself so
that different versions
- // of groovy can be used
+ // Keep this plugin on the repository Groovy version instead of the
shell CLI's transitive Groovy line.
Review Comment:
This comment implies the excluded Groovy comes specifically from
`:grails-shell-cli`, but that project depends on `org.apache.groovy` artifacts
(Groovy 4/5 line). Since the exclusion here is for `org.codehaus.groovy`
(legacy Groovy 2/3 group), the comment should be adjusted to match what is
actually being excluded to avoid confusion for future maintainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
