borinquenkid opened a new pull request, #15833:
URL: https://github.com/apache/grails-core/pull/15833

   ## Summary
   
   Stacked on #15832 (PR4 — re-add Neo4j example apps and docs into the 
monorepo). This is PR5 of the migration: brings `grails-datastore-gorm-neo4j` 
into compliance with the repo's Checkstyle/CodeNarc gate.
   
   - Fixes all 655 pre-existing Checkstyle violations across 23 Java files 
(import ordering, wildcard-import expansion, unused imports, whitespace/paren 
spacing, blank-line separators, trailing newlines, indentation, and 
operator/separator wrapping) plus the remaining CodeNarc violations across 7 
Groovy files (`grails.neo4j.*`, `grails.neo4j.mapping.MappingBuilder`, 
`grails.neo4j.services.Cypher`).
   - A whole-module auto-reformat pass introduced two real bugs alongside the 
style fixes, both caught and fixed: a mangled ternary in 
`GraphGormMappingFactory.groovy` that broke Groovy compilation, and a plain 
class in `Neo4jSession.java` silently converted into a Java `record` with a 
rewritten `equals()` (reverted to the original class — no behavior change 
intended here).
   - Every changed file's diff was independently reviewed hunk-by-hunk (batched 
across 8 passes) specifically for reformat-induced correctness risk — altered 
operators, mis-wrapped expressions, dropped imports, closure/brace mixups, 
Cypher query-string mutations. No other issues found.
   - No behavioral changes: purely style/formatting.
   
   ## Test plan
   
   - [x] `./gradlew :grails-datastore-gorm-neo4j:compileGroovy 
:grails-datastore-gorm-neo4j:compileTestGroovy` — clean
   - [x] `./gradlew :grails-datastore-gorm-neo4j:codeStyle` — 0 Checkstyle 
violations (down from 655), 0 CodeNarc violations
   - [x] `./gradlew :grails-datastore-gorm-neo4j:test` — 547 tests, 7 
pre-existing failures; confirmed via `git stash` comparison that the same 7 
fail identically against the original unformatted code (not a regression from 
this change)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to