jamesfredley commented on PR #15803: URL: https://github.com/apache/grails-core/pull/15803#issuecomment-4929439463
Updated the summary formatting to follow the repository PR template and expanded the URL-scope rationale in the body. Short version: this PR preserves the existing URL-keyed contract (`generateToken(url)`, `isValid(url, token)`, `resetToken(url, token)`, and `TOKEN_URI`) rather than changing token scope. Keeping that contract limits replay to the action URL that generated the token, avoids a compatibility change in this hardening PR, and still fixes the concrete security issues here: unbounded token storage and non-atomic consume. Verification: `./gradlew --no-daemon :grails-test-suite-web:test --tests "org.grails.web.servlet.mvc.SynchronizerTokensHolderTests" :grails-test-suite-uber:test --tests "org.grails.web.metaclass.WithFormMethodTests"` passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
