bito-code-review[bot] commented on PR #15949:
URL: https://github.com/apache/grails-core/pull/15949#issuecomment-4930189333
<!-- Bito Reply -->
The suggestion to scope the `management.endpoint.heapdump.access:
unrestricted` configuration to a specific profile is appropriate. Currently,
this configuration is applied globally in
`grails-test-examples/external-configuration/grails-app/conf/application.yml`,
which could inadvertently expose the heapdump endpoint in non-test
environments. Scoping it to the `test` profile would ensure this relaxed
security setting is only active during testing.
**grails-test-examples/external-configuration/grails-app/conf/application.yml**
```
---
# Lenient enum values resolved via environment.getProperty(name, Access)
rather than
# relaxed configuration-property binding - regression test for issue #15818
spring:
profiles: test
management:
endpoint:
heapdump:
access: unrestricted
threaddump:
access: read-only
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
