jdaugherty commented on code in PR #15976:
URL: https://github.com/apache/grails-core/pull/15976#discussion_r3565448032
##########
grails-core/src/main/resources/META-INF/additional-spring-configuration-metadata.json:
##########
@@ -28,6 +28,12 @@
"description": "A list of versions to exclude from the banner.",
"type": "java.util.List<grails.boot.GrailsBanner.DefaultVersionOption>"
},
+ {
+ "name": "grails.converters.encoding",
Review Comment:
`grails.converters.encoding` is already declared in
`grails-web-core/src/main/resources/META-INF/spring-configuration-metadata.json`
(line ~211) with the narrower description "The character encoding for
converter output (JSON or XML)." — this adds a second declaration of the same
property with a different description, so IDEs will surface
duplicate/conflicting entries. Suggest updating the existing grails-web-core
entry's description in place and dropping this addition. The user-facing doc
table (`grails-doc/src/en/ref/Configuration/Application Properties.adoc`, ~line
289) carries the same stale JSON/XML-only wording and should be broadened too,
since this PR extends the key's effect to respond()-rendered content types.
Also, if the entry stays here, it's currently inserted between the two
`grails.banner.versions.*` entries — worth moving out of that group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
