jamesfredley commented on PR #15824: URL: https://github.com/apache/grails-core/pull/15824#issuecomment-4986244181
## Review feedback addressed Merged the latest `8.0.x` and pushed. **Copilot review comment (unknown-namespace error path initializing XML reader/context):** already satisfied on this branch. The `"No namespace handler found for URI: ..."` error builds its `Location` directly from the already-available `beanBuildResource` (`new Location(beanBuildResource)`), so it does **not** call `getXmlSupport().getReaderContext(...)` and never forces `XmlBeanDefinitionReader` / unrefreshed-context initialization in the exception path. The regression test `testUnknownNamespaceDoesNotInitializeXmlReaderForErrorLocation` locks this in by making context initialization throw and asserting the namespace-handler error still surfaces. **Follow-up (documented, not changed here):** the lazy XML refactor means `setClassLoader` no longer dispatches to the protected `initializeBeanBuilderForClassLoader` hook. No in-repo `BeanBuilder` subclass overrides that hook, so this only affects hypothetical external subclasses; noting it here in case we want to preserve the hook dispatch in a follow-up. Local verification: `:grails-spring:test --tests BeanBuilderTests` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
