Copilot commented on code in PR #15993:
URL: https://github.com/apache/grails-core/pull/15993#discussion_r3602346578
##########
grails-shell-cli/build.gradle:
##########
@@ -115,6 +115,7 @@ dependencies {
// Testing
testImplementation 'org.slf4j:slf4j-simple'
+ testImplementation 'ch.qos.logback:logback-classic'
testImplementation 'org.spockframework:spock-core'
Review Comment:
`grails-shell-cli` test runtime will contain multiple SLF4J providers
(runtimeOnly `slf4j-simple` plus test `logback-classic` and `slf4j-simple`).
SLF4J 2.x treats this as an ambiguous binding and provider selection can become
order-dependent, which can make tests flaky or change logging behavior across
environments. Prefer having exactly one provider on the test classpath (and
ideally one provider overall).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
