sanjana2505006 commented on code in PR #15339:
URL: https://github.com/apache/grails-core/pull/15339#discussion_r3608959279
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/database/TestContainers.java:
##########
@@ -83,7 +83,10 @@ public void apply(GeneratorContext generatorContext) {
}
if (generatorContext.isFeaturePresent(MongoFeature.class) ||
generatorContext.isFeaturePresent(MongoGorm.class)) {
-
generatorContext.addDependency(testContainerTestDependency("mongodb"));
+ generatorContext.addDependency(Dependency.builder()
+ .groupId("org.apache.grails.testing")
Review Comment:
Thanks @jdaugherty, reworked it. It's now a regular mongodb-testing-support
feature you pick explicitly, and I added a validator so it can only be selected
alongside mongo-sync or gorm-mongodb. TestContainers is left as-is. Added a
docs page and tests too. Let me know if this is closer to what you had in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
