The GitHub Actions job "CI" on grails-core.git/feat/artefact-index-seed has 
succeeded.
Run started by GitHub user borinquenkid (triggered by borinquenkid).

Head commit for run:
7662a262f16ee6f2e9d4fe3d232b3d1686320f19 / Walter Duque de Estrada 
<[email protected]>
Address unresolved review feedback on ArtefactIndexReader

Five review comments (Copilot, jdaugherty) on the artefact-index reader
were left unaddressed by the prior commit, which only closed a coverage
gap:

- Widen read()'s catch to IOException | RuntimeException so a failure
  in IOUtils.findRootResource (e.g. IllegalStateException) or class
  loading (e.g. SecurityException) falls back to scanning instead of
  failing startup.
- Add debug logging for index-used / index-rejected / index-disabled
  outcomes, since both paths were previously silent.
- Add a grails.artefactIndex.disabled system property kill-switch to
  force classpath scanning.
- Skip blank lines instead of rejecting the whole index on one; this
  also aligns the code with the class javadoc, which already documented
  blank lines as insignificant.
- Document the semantic differences from ClassPathScanner (no
  annotation check, ignored-root-packages not applied) that an index
  producer must account for.

Co-Authored-By: Claude Sonnet 5 <[email protected]>

Report URL: https://github.com/apache/grails-core/actions/runs/30286160390

With regards,
GitHub Actions via GitBox

Reply via email to