The GitHub Actions job "Code Analysis" on grails-core.git/perf/8.0.x-jmh-pr-benchmarks has succeeded. Run started by GitHub user jamesfredley (triggered by jamesfredley).
Head commit for run: ed2db8a1aff7cb870570f653a59c6a22a3d196d7 / James Fredley <[email protected]> Close JMH metadata stream and run comparison tests in CI Address review feedback on the JMH benchmark reporting workflow. The classpath metadata merge read line-oriented entries with getInputStream(entry).getText(...) and never closed the stream, while the two neighbouring Properties reads already used withCloseable. That branch handles every META-INF/services and META-INF/groovy entry across the whole benchmark runtime classpath, so it was the most frequently executed of the three and could leak file handles across a large dependency set. It now closes the stream like the others; the merged output is unchanged. The comparison script's unit tests were not executed anywhere, leaving the reporting logic unguarded against regressions. They now run in the benchmark job immediately after checkout, before the JDK and Gradle setup and before the paired build and measurement steps, so a broken reporter fails within seconds rather than after an hour of benchmarking. Running them in the shard job also covers pull requests from forks, which never reach the reporting job. That step is deliberately permitted to fail the job. The workflow's advisory-only rule applies to performance regressions; a comparison script that does not pass its own tests invalidates every number the run produces, so it should stop the run rather than publish results. Assisted-by: claude-code:claude-opus-5 Report URL: https://github.com/apache/grails-core/actions/runs/30672042323 With regards, GitHub Actions via GitBox
