jdaugherty commented on PR #16078: URL: https://github.com/apache/grails-core/pull/16078#issuecomment-5153959171
This PR is attempting to adopt org.jline's fork, but additional issues found as part of this work: 1. the cli split needs it's own test source set split so tests have a similar classpath to production 2. any CLI specific class (i.e. AnsiConsoleUrlMappingsRenderer) needs moved to the CLI source set 3. jline/jansi needs eliminated completely from the production classpath as it's likely only used for the console / shell (this needs proven / tested) 4. It's very likely jansi can be entirely removed now since adopting the jline specific makes it a dependency of jline and we don't need a third party library 5. the grails-console probably should be a cli only library and not on the production classpath -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
