jamesfredley commented on PR #16082: URL: https://github.com/apache/grails-core/pull/16082#issuecomment-5159600864
Merged https://github.com/apache/grails-core/pull/16086 (`82ebbd775e`) into this branch. **Review summary (acceptable):** jdaugherty's follow-up correctly fixes a real regression from routing templates through `processResources` - the `**/*.gsp` exclusion was silently emptying GSP templates from scaffolding and spring-security-ui jars. Design matches the unique-output model we converged on, with the right refinements: - Staging dirs attached via `sourceSet.output.dir(builtBy:)` so they never re-enter `processResources` filters - Still `Copy` (not `Sync`) for consumer BC - `doFirst` wipe of own destination only when the task runs (up-to-date preserved) - Stronger TestKit coverage (GSP survival, staging outside process*Resources, delete-without-clean) Local: all 5 `PluginScriptCommandPackagingSpec` features green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
