The GitHub Actions job "CI" on grails-core.git/refactor/remove-gspcompile-configuration has succeeded. Run started by GitHub user codeconsole (triggered by codeconsole).
Head commit for run: 80bf683305c8223fac1309295c3f801852674c51 / Scott Murphy Heiberg <[email protected]> Remove the vestigial gspCompile configuration Follow-up to #16068, which removed the hardcoded servlet API dependency that gspCompile carried. The configuration was introduced in 2014 as the classpath for the original Ant-based GSP compiler, which ran via IsolatedAntBuilder: antBuilder.withClasspath(project.configurations.gspCompile) It held the two artifacts that compiler needed - grails-web-gsp and the servlet API. When GSP compilation moved to the forked GroovyPageForkCompileTask, whose classpath is compileClasspath + gspCompile + compiled classes + providedCompile, the grails-web-gsp entry was dropped and only the servlet API line remained. #16068 removed that, leaving a configuration that is empty for every build and contributes no files to the GSP compile classpath. GSPs continue to compile against compileClasspath, the project's compiled classes and providedCompile, which is what actually supplies everything GSP compilation needs. This is a behavior break for any build that declares dependencies on gspCompile: those fail with "Could not find method gspCompile()". Documented in the Grails 8 upgrade guide with the migration to compileOnly, which lands on the same compile classpath. Adds GroovyPagePluginFunctionalSpec, a TestKit spec that applies org.apache.grails.gradle.grails-gsp and asserts the configuration is gone while compileGroovyPages and compileWebappGroovyPages still resolve the compile classpath, provided dependencies and compiled classes. Verified the first assertion fails when the configuration is restored. Verified with :grails-gradle-plugins:test --rerun-tasks (90 tests), :grails-gradle-plugins:check, aggregateViolations (Checkstyle, CodeNarc, PMD, SpotBugs all clean) and :grails-doc:publishGuide. Report URL: https://github.com/apache/grails-core/actions/runs/30775665834 With regards, GitHub Actions via GitBox
