borinquenkid opened a new pull request, #16151: URL: https://github.com/apache/grails-core/pull/16151
## Summary - Add mock-based Spock coverage for `org.grails.datastore.gorm.events` (core), which had little to no coverage: `DomainEventListener` 0%→93% lines/93% branches, `AutoTimestampEventListener` 84%/61%→98%/83%, `DefaultApplicationEventPublisher` 0%→95%/81%, `ConfigurableApplicationContextEventPublisher` 0%→100% - Remove a confirmed-dead code path in `DomainEventListener.invokeEvent`: the event-argument-accepting hook branch could never execute since `findAndCacheEvent` only ever caches zero-argument methods (confirmed by decompiling spring-core's `ReflectionUtils.findMethod`) - Deprecate the now-vestigial `event` parameter on the 8 public 3-arg `before*/after*` overloads (scheduled for removal in 9.0); the 2-arg overloads are now canonical and `onPersistenceEvent` calls them directly - Fix IntelliJ warnings across the package: raw-type parameterization, `.equals()`→`==`, a `Set.removeAll(List)` performance smell, duplicated `publishEvent` overload bodies deduplicated into a shared method, and a null-safety fix on `supportsEventType` (Spring 7's `SmartApplicationListener.supportsEventType` parameter is `@Nullable`) ## Test plan - [x] `:grails-datamapping-core:test` full suite green - [x] `:grails-datamapping-rx:test` full suite green (verifies the rx subclasses still compile/pass against the changed core signatures) - [x] `:grails-datamapping-core:codeStyle` / `:grails-datamapping-rx:codeStyle` — zero Checkstyle/CodeNarc violations - [x] jacoco coverage reviewed per class before/after -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
