codecov[bot] commented on PR #16152: URL: https://github.com/apache/grails-core/pull/16152#issuecomment-5300924759
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16152?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.66667%` with `124 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 52.7545%. Comparing base ([`a83f874`](https://app.codecov.io/gh/apache/grails-core/commit/a83f87480e0c0138caa5a7191a053b1e59a64066?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e456f0a`](https://app.codecov.io/gh/apache/grails-core/commit/e456f0a60cf34d7cc6b834bcd44c369aa8f1d1b8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16152?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ails/compiler/web/ControllerActionTransformer.java](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-controllers%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fcompiler%2Fweb%2FControllerActionTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnRyb2xsZXJzL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2NvbXBpbGVyL3dlYi9Db250cm9sbGVyQWN0aW9uVHJhbnNmb3JtZXIuamF2YQ==) | 19.5122% | [29 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rails/web/json/PathCapturingJSONWriterWrapper.java](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fjson%2FPathCapturingJSONWriterWrapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2pzb24vUGF0aENhcHR1cmluZ0pTT05Xcml0ZXJXcmFwcGVyLmphdmE=) | 0.0000% | [30 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/grails/web/mapping/DefaultUrlMappingsHolder.java](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-web-url-mappings%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fmapping%2FDefaultUrlMappingsHolder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi11cmwtbWFwcGluZ3Mvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL21hcHBpbmcvRGVmYXVsdFVybE1hcHBpbmdzSG9sZGVyLmphdmE=) | 60.0000% | [5 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...roovy/grails/web/databinding/DataBindingUtils.java](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-web-databinding%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fweb%2Fdatabinding%2FDataBindingUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1kYXRhYmluZGluZy9zcmMvbWFpbi9ncm9vdnkvZ3JhaWxzL3dlYi9kYXRhYmluZGluZy9EYXRhQmluZGluZ1V0aWxzLmphdmE=) | 90.3226% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...b/controllers/api/ControllersDomainBindingApi.java](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-controllers%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fcontrollers%2Fapi%2FControllersDomainBindingApi.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnRyb2xsZXJzL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3BsdWdpbnMvd2ViL2NvbnRyb2xsZXJzL2FwaS9Db250cm9sbGVyc0RvbWFpbkJpbmRpbmdBcGkuamF2YQ==) | 75.0000% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../GrailsInterceptorHandlerInterceptorAdapter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-interceptors%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Finterceptors%2FGrailsInterceptorHandlerInterceptorAdapter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWludGVyY2VwdG9ycy9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9pbnRlcmNlcHRvcnMvR3JhaWxzSW50ZXJjZXB0b3JIYW5kbGVySW50ZXJjZXB0b3JBZGFwdGVyLmdyb292eQ==) | 80.9524% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...sting/AbstractGrailsMockHttpServletResponse.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-test-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Ftesting%2FAbstractGrailsMockHttpServletResponse.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXRlc3QtY29yZS9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3Rlc3RpbmcvQWJzdHJhY3RHcmFpbHNNb2NrSHR0cFNlcnZsZXRSZXNwb25zZS5ncm9vdnk=) | 0.0000% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...eb/servlet/DefaultGrailsApplicationAttributes.java](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2FDefaultGrailsApplicationAttributes.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3NlcnZsZXQvRGVmYXVsdEdyYWlsc0FwcGxpY2F0aW9uQXR0cmlidXRlcy5qYXZh) | 70.0000% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...y/org/grails/web/servlet/mvc/GrailsWebRequest.java](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fmvc%2FGrailsWebRequest.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3NlcnZsZXQvbXZjL0dyYWlsc1dlYlJlcXVlc3QuamF2YQ==) | 92.3077% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/grails/web/errors/GrailsExceptionResolver.java](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-web-mvc%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Ferrors%2FGrailsExceptionResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1tdmMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2Vycm9ycy9HcmFpbHNFeGNlcHRpb25SZXNvbHZlci5qYXZh) | 75.0000% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [22 more](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## 8.0.x #16152 +/- ## ================================================== + Coverage 52.6311% 52.7545% +0.1234% - Complexity 18436 18534 +98 ================================================== Files 2037 2037 Lines 96500 96568 +68 Branches 16860 16861 +1 ================================================== + Hits 50789 50944 +155 + Misses 38284 38200 -84 + Partials 7427 7424 -3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16152?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...s/web/async/AsyncWebRequestPromiseDecorator.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fasync%2FAsyncWebRequestPromiseDecorator.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hc3luYy9Bc3luY1dlYlJlcXVlc3RQcm9taXNlRGVjb3JhdG9yLmdyb292eQ==) | `20.0000% <100.0000%> (ø)` | | | [.../src/main/groovy/grails/artefact/Controller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-controllers%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fartefact%2FController.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnRyb2xsZXJzL3NyYy9tYWluL2dyb292eS9ncmFpbHMvYXJ0ZWZhY3QvQ29udHJvbGxlci5ncm9vdnk=) | `0.0000% <ø> (ø)` | | | [...efact/controller/support/ResponseRedirector.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-controllers%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fartefact%2Fcontroller%2Fsupport%2FResponseRedirector.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnRyb2xsZXJzL3NyYy9tYWluL2dyb292eS9ncmFpbHMvYXJ0ZWZhY3QvY29udHJvbGxlci9zdXBwb3J0L1Jlc3BvbnNlUmVkaXJlY3Rvci5ncm9vdnk=) | `0.0000% <ø> (ø)` | | | [.../web/gsp/io/GrailsConventionGroovyPageLocator.java](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fgsp%2Fio%2FGrailsConventionGroovyPageLocator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvZ3NwL2lvL0dyYWlsc0NvbnZlbnRpb25Hcm9vdnlQYWdlTG9jYXRvci5qYXZh) | `45.7143% <100.0000%> (ø)` | | | [...ovy/org/grails/gsp/jsp/GroovyPagesPageContext.java](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-jsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fgsp%2Fjsp%2FGroovyPagesPageContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWpzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9nc3AvanNwL0dyb292eVBhZ2VzUGFnZUNvbnRleHQuamF2YQ==) | `64.1975% <100.0000%> (ø)` | | | [...roovy/org/grails/gsp/jsp/PageContextFactory.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-jsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fgsp%2Fjsp%2FPageContextFactory.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWpzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9nc3AvanNwL1BhZ2VDb250ZXh0RmFjdG9yeS5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [.../grails/plugins/web/api/MimeTypesApiSupport.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-mimetypes%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fapi%2FMimeTypesApiSupport.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLW1pbWV0eXBlcy9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hcGkvTWltZVR5cGVzQXBpU3VwcG9ydC5ncm9vdnk=) | `89.5833% <100.0000%> (ø)` | | | [...vy/grails/artefact/controller/RestResponder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-rest-transforms%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fartefact%2Fcontroller%2FRestResponder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXJlc3QtdHJhbnNmb3Jtcy9zcmMvbWFpbi9ncm9vdnkvZ3JhaWxzL2FydGVmYWN0L2NvbnRyb2xsZXIvUmVzdFJlc3BvbmRlci5ncm9vdnk=) | `0.0000% <ø> (ø)` | | | [...groovy/grails/testing/web/GrailsWebUnitTest.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-testing-support-web%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Ftesting%2Fweb%2FGrailsWebUnitTest.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXRlc3Rpbmctc3VwcG9ydC13ZWIvc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy90ZXN0aW5nL3dlYi9HcmFpbHNXZWJVbml0VGVzdC5ncm9vdnk=) | `100.0000% <ø> (ø)` | | | [...ovy/grails/web/servlet/mvc/GrailsParameterMap.java](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fweb%2Fservlet%2Fmvc%2FGrailsParameterMap.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy93ZWIvc2VydmxldC9tdmMvR3JhaWxzUGFyYW1ldGVyTWFwLmphdmE=) | `78.8732% <100.0000%> (+4.7725%)` | :arrow_up: | | ... and [38 more](https://app.codecov.io/gh/apache/grails-core/pull/16152?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16152/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
