borinquenkid opened a new pull request, #16153: URL: https://github.com/apache/grails-core/pull/16153
## Summary - Added Spock unit tests for every previously-untested class in `org.grails.datastore.gorm.jdbc` and its `connections` subpackage (DatabaseDriver, MultiTenantConnection, MultiTenantDataSource, PropertyOrigin, OriginCapablePropertyValue, RelaxedNames, RelaxedConversionService, RelaxedDataBinder, DataSourceSettings, DataSourceSettingsBuilder, DataSourceConnectionSource, DataSourceConnectionSourceFactory, CachedDataSourceConnectionSourceFactory, SpringDataSourceConnectionSourceFactory). - Fixed a potential NPE in `DataSourceConnectionSource.close()`: `DelegatingDataSource.getTargetDataSource()` can return `null`, which previously caused an immediate NPE on the following `getClass()` call while unwrapping nested delegating data sources. Added a regression test. - Renamed a shadowed local variable in `DataSourceSettings.toProperties()` (it collided with the field and the `@Builder`-generated fluent setter of the same name). - Marked `SpringDataSourceConnectionSourceFactory.setApplicationContext`'s parameter `@NonNull`. ## Test plan - [x] `./gradlew :grails-datamapping-core:test` - [x] `./gradlew :grails-datamapping-core:codeStyle` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
