bito-code-review[bot] commented on PR #16155:
URL: https://github.com/apache/grails-core/pull/16155#issuecomment-5304823724
<!-- Bito Reply -->
The concern regarding the conversion of `protected` instance methods to
`static` is valid. In Groovy, changing an instance method to `static` breaks
binary compatibility for any subclasses that override these methods, as static
methods are not polymorphic and cannot be overridden.
If these changes were made solely to satisfy static analysis inspections, it
is recommended to revert them to instance methods and suppress the inspection,
consistent with existing patterns in the repository.
**grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/proxy/GroovyProxyFactory.groovy**
```
@CompileDynamic
protected Serializable getIdDynamic(obj) {
if (obj.respondsTo('getId')) {
return (Serializable)obj.invokeMethod('getId', null)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
