The GitHub Actions job "SiteMesh 2 Compatibility" on grails-core.git/fix/flaky-per-test-recording-spec has succeeded. Run started by GitHub user borinquenkid (triggered by borinquenkid).
Head commit for run: 5fa312413436b34f286b01e1643372052003ce57 / Walter Duque de Estrada <[email protected]> Address review feedback: fix restart failure handling, driver leak, and test hermeticity - restartVncRecordingContainer() now clears the vncRecordingContainer field before attempting to start its replacement, and stops the replacement if start() fails, so a stale reference to an already-removed container can no longer make the next saveRecordingToFile() throw an uncaught NotFoundException. GebRecordingTestListener now also tolerates the resulting NullPointerException from an unavailable recording container. - stop() now quits the WebDriver session before stopping the container, fulfilling the promise made by disabling Geb's own driver caching/quitting - previously every container recycle abandoned a RemoteWebDriver and its HTTP connection pool. - PerTestRecordingSpec's minimum-recording-size check now polls with a timeout instead of asserting immediately, and corrects a comment that misstated Files.mismatch's pass/fail semantics. - WebDriverContainerHolderSpec no longer asserts through reflection on a private testcontainers field, and both it and the new GebRecordingTestListenerSpec clear grails.geb.* system properties around the spec so GrailsGebSettings' constructor can't fail on external state. Co-Authored-By: Claude Sonnet 5 <[email protected]> Report URL: https://github.com/apache/grails-core/actions/runs/32393841675 With regards, GitHub Actions via GitBox
