codeconsole commented on code in PR #16209:
URL: https://github.com/apache/grails-core/pull/16209#discussion_r3847658952
##########
grails-web-databinding/src/main/groovy/grails/web/databinding/GrailsWebDataBinder.groovy:
##########
@@ -545,7 +545,17 @@ class GrailsWebDataBinder extends SimpleDataBinder {
}
}
if (persistentInstance == null) {
- if (item instanceof Map || item instanceof
DataBindingSource) {
+ if (item == null ||
referencedType.isAssignableFrom(item.getClass())) {
Review Comment:
Pushed as `f408864` — `def listValue` → `List listValue` on line 508, where
the value is introduced. That leaves `item.getClass()` uncast, matching the
array branch above and the Map branch below.
Thanks for catching it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
