codecov[bot] commented on PR #16230: URL: https://github.com/apache/grails-core/pull/16230#issuecomment-5430155738
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16230?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `74.84663%` with `41 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.2019%. Comparing base ([`c985acb`](https://app.codecov.io/gh/apache/grails-core/commit/c985acb1ab9c4813adfd1a08e4cebe05684557c8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b3febc2`](https://app.codecov.io/gh/apache/grails-core/commit/b3febc2d20b974b1afd89b81142c9fd1da03dfc5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 16 commits behind head on 8.0.x. | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16230?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...tory/future/CompletableFuturePromiseFactory.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fcore%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fasync%2Ffactory%2Ffuture%2FCompletableFuturePromiseFactory.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL2NvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvYXN5bmMvZmFjdG9yeS9mdXR1cmUvQ29tcGxldGFibGVGdXR1cmVQcm9taXNlRmFjdG9yeS5ncm9vdnk=) | 72.3404% | [10 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ync/factory/future/CompletableFuturePromise.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fcore%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fasync%2Ffactory%2Ffuture%2FCompletableFuturePromise.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL2NvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvYXN5bmMvZmFjdG9yeS9mdXR1cmUvQ29tcGxldGFibGVGdXR1cmVQcm9taXNlLmdyb292eQ==) | 79.4872% | [6 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rc/main/groovy/grails/async/web/WebPromises.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fasync%2Fweb%2FWebPromises.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvZ3JhaWxzL2FzeW5jL3dlYi9XZWJQcm9taXNlcy5ncm9vdnk=) | 69.2308% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../web/async/mvc/AsyncActionResultTransformer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fasync%2Fmvc%2FAsyncActionResultTransformer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hc3luYy9tdmMvQXN5bmNBY3Rpb25SZXN1bHRUcmFuc2Zvcm1lci5ncm9vdnk=) | 57.1429% | [2 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...b/mapping/mvc/UrlMappingsInfoHandlerAdapter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-web-url-mappings%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fmapping%2Fmvc%2FUrlMappingsInfoHandlerAdapter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi11cmwtbWFwcGluZ3Mvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL21hcHBpbmcvbXZjL1VybE1hcHBpbmdzSW5mb0hhbmRsZXJBZGFwdGVyLmdyb292eQ==) | 50.0000% | [2 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## 8.0.x #16230 +/- ## ================================================== + Coverage 54.1599% 54.2019% +0.0420% + Complexity 20316 20301 -15 ================================================== Files 2107 2101 -6 Lines 101132 101026 -106 Branches 17920 17913 -7 ================================================== - Hits 54773 54758 -15 + Misses 38551 38466 -85 + Partials 7808 7802 -6 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16230?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../grails/async/factory/PromiseFactoryBuilder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fcore%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fasync%2Ffactory%2FPromiseFactoryBuilder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL2NvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvYXN5bmMvZmFjdG9yeS9Qcm9taXNlRmFjdG9yeUJ1aWxkZXIuZ3Jvb3Z5) | `100.0000% <100.0000%> (ø)` | | | [...ctory/future/CachedThreadPoolPromiseFactory.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fcore%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fasync%2Ffactory%2Ffuture%2FCachedThreadPoolPromiseFactory.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL2NvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvYXN5bmMvZmFjdG9yeS9mdXR1cmUvQ2FjaGVkVGhyZWFkUG9vbFByb21pc2VGYWN0b3J5Lmdyb292eQ==) | `53.3333% <ø> (-13.3333%)` | :arrow_down: | | [...ails/async/factory/future/FutureTaskPromise.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fcore%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fasync%2Ffactory%2Ffuture%2FFutureTaskPromise.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL2NvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvYXN5bmMvZmFjdG9yeS9mdXR1cmUvRnV0dXJlVGFza1Byb21pc2UuZ3Jvb3Z5) | `68.2927% <ø> (-4.8781%)` | :arrow_down: | | [...oovy/grails/async/web/AsyncGrailsWebRequest.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fasync%2Fweb%2FAsyncGrailsWebRequest.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvZ3JhaWxzL2FzeW5jL3dlYi9Bc3luY0dyYWlsc1dlYlJlcXVlc3QuZ3Jvb3Z5) | `58.5366% <ø> (ø)` | | | [...s/web/async/AsyncWebRequestPromiseDecorator.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fasync%2FAsyncWebRequestPromiseDecorator.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hc3luYy9Bc3luY1dlYlJlcXVlc3RQcm9taXNlRGVjb3JhdG9yLmdyb292eQ==) | `68.2927% <ø> (-7.3171%)` | :arrow_down: | | [...yncWebRequestPromiseDecoratorLookupStrategy.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fasync%2FAsyncWebRequestPromiseDecoratorLookupStrategy.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hc3luYy9Bc3luY1dlYlJlcXVlc3RQcm9taXNlRGVjb3JhdG9yTG9va3VwU3RyYXRlZ3kuZ3Jvb3Z5) | `66.6667% <ø> (-33.3333%)` | :arrow_down: | | [...gins/web/async/ControllersAsyncGrailsPlugin.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fasync%2FControllersAsyncGrailsPlugin.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hc3luYy9Db250cm9sbGVyc0FzeW5jR3JhaWxzUGx1Z2luLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | | | [...grails/plugins/web/async/GrailsAsyncContext.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fasync%2FGrailsAsyncContext.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hc3luYy9HcmFpbHNBc3luY0NvbnRleHQuZ3Jvb3Z5) | `0.0000% <ø> (ø)` | | | [...ins/web/async/GrailsWebRequestTaskDecorator.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fasync%2FGrailsWebRequestTaskDecorator.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hc3luYy9HcmFpbHNXZWJSZXF1ZXN0VGFza0RlY29yYXRvci5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...plugins/web/async/spring/PromiseFactoryBean.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fasync%2Fspring%2FPromiseFactoryBean.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hc3luYy9zcHJpbmcvUHJvbWlzZUZhY3RvcnlCZWFuLmdyb292eQ==) | `0.0000% <ø> (ø)` | | | ... and [5 more](https://app.codecov.io/gh/apache/grails-core/pull/16230?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [16 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16230/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
