Copilot commented on code in PR #16243:
URL: https://github.com/apache/grails-core/pull/16243#discussion_r3882460811
##########
grails-forge/grails-forge-web-netty/build.gradle:
##########
@@ -22,6 +22,7 @@ plugins {
id 'org.apache.grails.buildsrc.properties'
id 'org.apache.grails.buildsrc.dependency-validator'
id 'io.micronaut.application' version "$micronautApplicationPluginVersion"
+ id 'com.gradleup.shadow' version '8.3.6'
Review Comment:
Hardcoding the Shadow plugin version in this module makes upgrades harder
and can cause version drift across subprojects. Consider moving this version
into a shared place (e.g., `gradle.properties` / a version catalog /
pluginManagement) similar to how `micronautApplicationPluginVersion` is handled.
##########
grails-forge/grails-forge-web-netty/build.gradle:
##########
@@ -22,6 +22,7 @@ plugins {
id 'org.apache.grails.buildsrc.properties'
id 'org.apache.grails.buildsrc.dependency-validator'
id 'io.micronaut.application' version "$micronautApplicationPluginVersion"
+ id 'com.gradleup.shadow' version '8.3.6'
}
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
Review Comment:
The plugin ID was switched to `com.gradleup.shadow`, but the file still
imports `com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar`. If this
plugin does not expose the same task type/package, the build will fail at
configuration time. A safer approach is to avoid the explicit class import and
configure the `shadowJar` task by name (or update the import/type to match the
plugin actually applied).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
