Copilot commented on code in PR #16256: URL: https://github.com/apache/grails-core/pull/16256#discussion_r3883777676
########## RELEASE.md: ########## @@ -309,18 +309,27 @@ the date you moved the distribution artifacts and report the release. ### Deploy the release to Grails Forge -Publish the released version to [Grails Forge](https://start.grails.org) using one of the [GCP Deploy Actions](https://github.com/apache/grails-core/actions) available in the `grails-core` repository. +Publish the released version to [Grails Forge](https://start.grails.org) using [Forge - AWS Elastic Beanstalk Deploy](https://github.com/apache/grails-core/actions/workflows/forge-deploy-aws.yml). -Grails Forge organizes deployments into version slots as follows: +There is one workflow and two choices: **Use workflow from** (the maintenance branch to build) and **slot**. -- **RELEASE** - Full Final Releases - https://github.com/apache/grails-core/actions/workflows/forge-deploy-release.yml -- **NEXT** - Milestones and Release Candidate for Next Release (also Next version snapshot prior to Milestone) - https://github.com/apache/grails-core/actions/workflows/forge-deploy-next.yml -- **SNAPSHOT** - current or next version snapshot - https://github.com/apache/grails-core/actions/workflows/forge-deploy-snapshot.yml -- **PREV** - previous release version - https://github.com/apache/grails-core/actions/workflows/forge-deploy-prev.yml -- **PREV-SNAPSHOT** - previous version snapshot - https://github.com/apache/grails-core/actions/workflows/forge-deploy-prev-snapshot.yml +| Slot | Host | Typical branch | +| --- | --- | --- | +| `latest` | `latest.grails.org` | current release line, for example `7.2.x` | +| `snapshot` | `snapshot.grails.org` | current snapshot line, for example `8.0.x` | +| `next` | `next.grails.org` | milestone / RC line | +| `prev` | `prev.grails.org` | previous release line | +| `prev-snapshot` | `prev-snapshot.grails.org` | previous snapshot line | -Use the action whose name matches the slot you want to deploy to.\ -In the **“Run workflow/Use workflow from”** dropdown, choose the release tag you just created. +Do not select a historical git tag in **Use workflow from**. The AWS workflow file is not on old tags. Snapshot slots can deploy from the maintenance branch. + +A tagged release that must match an exact tag is packaged locally, then uploaded to Elastic Beanstalk. From a checkout of that tag, copy `grails-forge/grails-forge-web-netty/aws/` from the matching maintenance branch, then from `grails-forge` run: Review Comment: The instruction to "copy `grails-forge/grails-forge-web-netty/aws/` from the matching maintenance branch" is ambiguous about the destination path in the tagged checkout. Clarify that it should be copied into the same path within the tag checkout before running the Gradle task. ########## grails-forge/docs/aws-elastic-beanstalk.md: ########## @@ -16,7 +16,7 @@ limitations under the License. # AWS Elastic Beanstalk Deployment Runbook -This runbook describes the AWS migration configuration in this repository. It is an operating procedure, not a statement that production traffic has already moved. +This runbook describes operating the five Forge API slots on AWS Elastic Beanstalk. Public DNS for `latest.grails.org`, `snapshot.grails.org`, `next.grails.org`, `prev.grails.org`, and `prev-snapshot.grails.org` points at the shared ALB. The UI remains at `https://start.grails.org`. Review Comment: This runbook now states that public DNS already points the slot hostnames at the shared ALB, but later it still says "Current cutover is manual in Cloudflare." That’s contradictory and makes the current-state guidance unclear. ########## grails-forge/docs/aws-elastic-beanstalk.md: ########## @@ -163,13 +163,11 @@ curl --fail --show-error --silent \ "https://${SLOT_HOSTNAME}/versions"; ``` -Repeat for all five hostnames. Success proves certificate selection, SNI, the host rule, target reachability, and the slot response before public DNS changes. +Repeat for all five hostnames. Success proves certificate selection, SNI, the host rule, and target reachability. Public DNS already CNAME's these hostnames to the ALB, so the same check works without `--connect-to`. Review Comment: Use "CNAMEs" (plural) instead of "CNAME's". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
