The GitHub Actions job "Groovy Snapshot Canary Build" on 
grails-core.git/feat/openapi-springdoc-8.0.x has succeeded.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
c2399053cc1c57b84407c647c8b9db90ead6dcb6 / Scott Murphy Heiberg 
<[email protected]>
Fix the defects a second review of the rewrite found

The largest is a regression from branching the string constraints on the
schema type: swagger describes a date, a UUID and a byte array as strings
too, and reading a string constraint from one of those throws. A domain
class with a Date property - dateCreated and lastUpdated are in most of
them - lost its schema entirely while every operation kept referring to
it. The branch is now on the property type, which is the test the
constraint itself applies.

Also fixed:

- expansion built the path from a convention whenever the mapping named
  neither controller nor action, so a mapping declared under a group
  prefix was described without the prefix, at paths the application does
  not serve. Both forms follow the mapping's own pattern now.
- an expanded operation declared a parameter named id whatever the path
  actually contained, so a mapping carrying another variable declared one
  parameter that was absent from the template and omitted one that was
  present.
- an optional token left its marker in the path key, which is not a path
  template.
- the identifier was qualified only for the action-expanding form, so a
  resources mapping and a mapping naming the action produced two
  operations with one identifier. The qualifier is now derived from the
  path, and applied wherever it is needed.
- a request body still referred to a command by its class name while it
  was registered under the name its @Schema declares.
- @Tag named a group nothing was in: the operations kept the controller
  name. A hidden controller published its tag as well.
- a nested generic argument was not followed, so List<List<Command>> left
  the element type undefined.
- a reference whose schema could not be built is dropped rather than left
  dangling, which for a code generator is worse than an operation with no
  shape.

Two tests asserted the behavior rather than the intent and were corrected
with the code: one expected the controller name where a tag was declared,
and one expected the identifier before it was qualified.

Report URL: https://github.com/apache/grails-core/actions/runs/33452946267

With regards,
GitHub Actions via GitBox

Reply via email to