The GitHub Actions job "CI" on 
grails-core.git/feature/mongodb-skip-index-build-8.0.x has succeeded.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
b873801b55a3026acdf74e87ea7ab35cabf39d29 / Scott Murphy Heiberg 
<[email protected]>
Cover the index build's failure and degradation paths

Codecov put the patch at 75%, and what it was missing was every path where
something goes wrong - which is where behaviour that has been claimed in the
documentation most needs pinning. Four of them are now covered:

- a declaration the server refuses, and one whose conflict cannot be
  reconciled, are counted and reported: the build carries on, the summary is
  raised to WARN and says how many failed
- a background build that fails logs the failure at error level, since nothing
  waits on that thread to notice it
- a background build interrupted by shutdown is logged as the shutdown it is,
  not as a failure
- a role that may create an index but not list the existing ones still gets its
  indexes, with the summary falling back to how many declarations it applied

The last two need conditions a server will not produce on demand, so the driver
is wrapped in a proxy that makes one operation fail or block. Only that one
method is intercepted; everything else is the real driver talking to the real
server, and the datastore under test is the real one built through its public
constructor.

Patch coverage is now 97.8%. What remains is two error branches in conflict
reconciliation that predate this change and are not reachable without a server
that contradicts itself.

Report URL: https://github.com/apache/grails-core/actions/runs/33477410196

With regards,
GitHub Actions via GitBox

Reply via email to