codeconsole commented on code in PR #16149:
URL: https://github.com/apache/grails-core/pull/16149#discussion_r3907631836
##########
grails-controllers/src/main/groovy/grails/artefact/controller/support/ResponseRedirector.groovy:
##########
@@ -122,7 +122,7 @@ trait ResponseRedirector implements WebAttributes {
throw new IllegalArgumentException("Invalid arguments for method
'redirect': $argMap")
}
- grails.web.mapping.ResponseRedirector redirector = new
grails.web.mapping.ResponseRedirector(grailsLinkGenerator)
+ grails.web.mapping.ResponseRedirector redirector = new
grails.web.mapping.ResponseRedirector(getGrailsLinkGenerator())
Review Comment:
Nothing wrong with them - that was leftover. The explicit call arrived with
a trait field cache this branch added and then removed again, and the removal
left the call site behind. There is no field named `grailsLinkGenerator`, so
the property resolves to the same getter either way.
Put back in 250034dc, which leaves the trait matching 8.0.x apart from the
`getCurrentRequest` change. The other call site, at `resolveNamespace`, is
explicit on 8.0.x already, so I left it alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
