Copilot commented on code in PR #16303:
URL: https://github.com/apache/grails-core/pull/16303#discussion_r3920060349
##########
.github/workflows/gradle.yml:
##########
@@ -780,12 +780,6 @@ jobs:
if: github.repository_owner == 'apache' && github.event_name == 'push'
needs: [ publish ]
runs-on: ubuntu-24.04
- # Documentation publishing targets a shared resource (the
apache/grails-website repo).
- # Share the static group used by the release documentation publish
(release.yml) so only
- # one documentation publish can run at a time across every branch; the
rest queue.
- concurrency:
- group: grails-docs-publish
- cancel-in-progress: false
steps:
Review Comment:
The snapshot docs publishing job no longer has a static concurrency group
shared with the release docs job. Because both workflows push to the same
`apache/grails-website` branch, removing this serialization can cause
intermittent push conflicts or partial publishes when multiple branches publish
around the same time.
##########
.github/workflows/release.yml:
##########
@@ -558,20 +558,14 @@ jobs:
run: |
echo "::group::Manual Grails Forge deployment"
echo "Deploy Forge via
https://github.com/apache/grails-core/actions/workflows/forge-deploy-aws.yml";
- echo "Use workflow from the maintenance branch. Choose slot latest,
snapshot, next, prev, or prev-snapshot."
+ echo "Use workflow from the maintenance branch. Choose slot latest,
snapshot, next, next-snapshot, prev, prev-snapshot, or older."
echo "Do not run this workflow from a historical git tag."
echo "::endgroup::"
docs:
environment: docs
name: "VOTE SUCCEEDED - Publish Documentation"
needs: [ publish, source, upload, release ]
runs-on: ubuntu-24.04
- # Documentation publishing targets a shared resource (the
apache/grails-website repo).
- # Use a static, branch-independent group so only one documentation publish
can run at a
- # time across every branch and across the snapshot publish in gradle.yml;
the rest queue.
- concurrency:
- group: grails-docs-publish
- cancel-in-progress: false
steps:
Review Comment:
The docs publishing job no longer has the branch/workflow-independent
concurrency group (previously `grails-docs-publish`). Since this job pushes to
the shared `apache/grails-website` repo, concurrent runs from different
branches/workflows (e.g., `gradle.yml` snapshot docs publishes) can race and
fail on push or publish interleavings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
