Copilot commented on code in PR #16304:
URL: https://github.com/apache/grails-core/pull/16304#discussion_r3920065611
##########
.github/workflows/gradle.yml:
##########
@@ -780,12 +780,6 @@ jobs:
if: github.repository_owner == 'apache' && github.event_name == 'push'
needs: [ publish ]
runs-on: ubuntu-24.04
Review Comment:
The docs publish job no longer uses the shared `grails-docs-publish`
concurrency group. Because this workflow also publishes to the shared
`apache/grails-website` repo, dropping the shared concurrency can allow
concurrent publishes across branches/workflows and cause conflicting pushes.
##########
.github/workflows/release.yml:
##########
@@ -558,20 +558,14 @@ jobs:
run: |
echo "::group::Manual Grails Forge deployment"
echo "Deploy Forge via
https://github.com/apache/grails-core/actions/workflows/forge-deploy-aws.yml";
- echo "Use workflow from the maintenance branch. Choose slot latest,
snapshot, next, prev, or prev-snapshot."
+ echo "Use workflow from the maintenance branch. Choose slot latest,
snapshot, next, next-snapshot, prev, prev-snapshot, or older."
echo "Do not run this workflow from a historical git tag."
echo "::endgroup::"
docs:
environment: docs
name: "VOTE SUCCEEDED - Publish Documentation"
needs: [ publish, source, upload, release ]
runs-on: ubuntu-24.04
Review Comment:
The docs publish job no longer has the shared `grails-docs-publish`
concurrency gate. Since this job pushes to the shared `apache/grails-website`
repo, removing the cross-workflow/branch concurrency can allow concurrent
publishes from different branches or workflows, causing conflicting pushes and
flaky failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
