jamesfredley commented on code in PR #16167:
URL: https://github.com/apache/grails-core/pull/16167#discussion_r3934563986
##########
.github/workflows/gradle.yml:
##########
@@ -204,6 +214,7 @@ jobs:
-PonlyCoreTests
-PskipCodeStyle
${{ matrix.shard_arguments }}
+ ${{ matrix.runner_arguments }}
Review Comment:
Not valid. GitHub Actions interpolates a missing matrix property as an empty
string (see the contexts reference: "If you attempt to dereference a
nonexistent property, it will evaluate to an empty string").
This workflow already depends on that: `matrix.shard_arguments` is only set
on the Windows shards, and Ubuntu/macOS still `${{ matrix.shard_arguments }}`
today. This PR's own CI ran the Ubuntu and Windows jobs without
`runner_arguments` defined; they did not fail at expression evaluation.
Leaving the other rows undefined matches the existing `shard_arguments`
pattern. No change.
##########
.github/workflows/gradle.yml:
##########
@@ -204,6 +214,7 @@ jobs:
-PonlyCoreTests
-PskipCodeStyle
${{ matrix.shard_arguments }}
+ ${{ matrix.runner_arguments }}
Review Comment:
Not valid. GitHub Actions interpolates a missing matrix property as an empty
string (see the contexts reference: "If you attempt to dereference a
nonexistent property, it will evaluate to an empty string").
This workflow already depends on that: `matrix.shard_arguments` is only set
on the Windows shards, and Ubuntu/macOS still `${{ matrix.shard_arguments }}`
today. This PR's own CI ran the Ubuntu and Windows jobs without
`runner_arguments` defined; they did not fail at expression evaluation.
Leaving the other rows undefined matches the existing `shard_arguments`
pattern. No change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
