The GitHub Actions job "SiteMesh 2 Compatibility" on 
grails-core.git/perf/request-path-8.0.x has succeeded.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
89b3890662dd0c1e27c512d73eddf1ef8fabe88c / Scott Murphy Heiberg 
<[email protected]>
chore: clear the residue review found in the request path branch

Three things review pointed at, none of which had a reason to be there.

ControllersAutoConfigurationSpec kept a hiddenMethodContextRunner helper with no
callers - a fixture for tests that ended up written another way.

FormTagLib.setConfiguration carried @GrailsCompileStatic, where the rest of that
file uses plain @CompileStatic and 8.0.x annotates the method not at all. It
arrived with the trait field cache this branch added and then removed, the same
way the explicit getGrailsLinkGenerator() call did. The method now differs from
8.0.x by nothing, so the annotation and its import go with it.

The upgrade note called the move from getCurrentRequest() to getRequest() a
rename. It is not: getRequest() has always been on Spring's
ServletRequestAttributes. What changed is that getCurrentRequest() no longer
returns anything different from it, so the note says that instead.

Report URL: https://github.com/apache/grails-core/actions/runs/34136590750

With regards,
GitHub Actions via GitBox

Reply via email to