bito-code-review[bot] commented on PR #16327:
URL: https://github.com/apache/grails-core/pull/16327#issuecomment-5602593627
<!-- Bito Reply -->
The pull request already replaces the previous test with new, more robust
tests that verify the producer-consumer relationship using provider wiring. The
new tests cover clean builds, incremental builds (up-to-date checks), and
change detection, which directly address the regression concerns regarding
cached-based scripts. Keeping the old test is unnecessary as the new
implementation provides better coverage for the fix.
**grails-gradle/plugins/src/test/groovy/org/grails/gradle/plugin/core/GrailsGroovyCompilerConfigSpec.groovy**
```
def "a generated user script is consumed during compilation and follows
changes"() {
given: 'a compiler script wired through its producer output provider'
setupTestResourceProject('compiler-config-generated-user-script')
when: 'a clean build compiles and runs source that needs both sets
of imports'
def first = executeTask('clean', ['verifyCompilation'])
then:
first.task(':generateUserConfigScript').outcome ==
TaskOutcome.SUCCESS
first.task(':generateCompileGroovyGrailsCompilerConfig').outcome ==
TaskOutcome.SUCCESS
first.task(':compileGroovy').outcome == TaskOutcome.SUCCESS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
