codeconsole commented on PR #16184:
URL: https://github.com/apache/grails-core/pull/16184#issuecomment-5651033126
@matrei All addressed, pushed as 3ac93a3aa9..16eb980bb8.
**Bug — unencoded attribute values** (3ac93a3aa9). Confirmed: with the
registrar's wiring `codecLookup` was null and `captureTagContent` wrote `<body
class=""><script>x</script>"></body>`. `@Autowired` on the field, as
`RenderSitemeshTagLib` has it. Two tests in `Sitemesh3LayoutTagLibSpec` pin the
encoded output and what an unwired lookup costs, and `StandaloneContextTest` in
the example asserts the context wires the lookup on both tag libraries — that
one fails with the declaration removed.
**Tests** (7dc87ac976, 3ceb572b79)
- `CoreGrailsPluginRegistrarSpec` now clears the Grails entries from
`APC_PRIORITY_LIST` before the feature and restores them after. Reverting
`registerWithAopConfigUtils()` in `CoreGrailsPlugin` now fails it; it did not
before.
- `GroovyPageCompilerSpec` points `generatedGroovyPagesDirectory` at its
`@TempDir`.
- `GspAutoConfigurationSpec` drives the contributed locator through
`findPage` and gets a `GroovyPageCompiledScriptSource` back. The registry
fixture names classes that exist, so reverting either `setPrecompiledGspMap` or
`paths.add(cleanUri(uri))` fails it in-module.
- `GroovyPagePluginFunctionalSpec`: the non-Grails project asserts `test`
depends on both `compileGroovyPages` and `compileWebappGroovyPages`; the Grails
project asserts neither.
- `StandaloneContextTest` asserts `pluginManager`, `grailsConfigProperties`
and `classLoader` are absent from the example's context.
**Docs** (16eb980bb8). The SiteMesh note no longer names
`Sitemesh3EnvironmentPostProcessor`. New guide page *The Web Layer → Groovy
Server Pages → GSP in a Spring Boot Application* covering the precompiled views
and when they are skipped, the `serverpath = '/'` requirement, the empty
`grailsUrlMappingsHolder`, `@Artefact("TagLib")` beans, and the `spring.gsp.*`
properties. The module README described sample applications that no longer
exist and is replaced.
**Design notes**
- `jspViewResolver` (3d23083278): moved out of `@Bean(name = {...})` into
`ReplaceViewResolverRegistrar`, which registers the alias only when no bean
definition holds the name. Two cases in `TagLibraryLookupRegistrarSpec` cover
both branches.
- Example (6ca3141d55): the selected rendering is a session attribute;
`JspViewTest` keeps its cookies rather than resetting application state. The
stale sentence was on `WebController.selectJsp` and is corrected — the
controller is always mapped, and what it checks is the servlet context at
request time.
**Process.** The 8.0.x-before-RC1 question is still open and is
@codeconsole's call, not something these commits settle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
