codeconsole commented on PR #16282:
URL: https://github.com/apache/grails-core/pull/16282#issuecomment-5655301271
Thanks for the approval — both nits taken in `40fe646ca6`.
**Import order.** The four `collection.*` / `core.Session` imports now sit
inside the existing `org.grails` block, alphabetically ahead of
`dirty.checking.*`.
**Subclass case symmetry.** Added `entity.hasChanged('shares')` to its
`then:`, so it mirrors the wrapper-side subclass case and pins that the setter
still flags the assignment when the old value is a `PersistentCollection` — the
thing the store persister relies on to re-wrap on save.
`DirtyCheckCollectionReassignmentSpec` is 21/21 green on this head.
Test-only change; no production code moved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
