codecov[bot] commented on PR #16340: URL: https://github.com/apache/grails-core/pull/16340#issuecomment-5658213873
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16340?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `72.34043%` with `104 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 56.1540%. Comparing base ([`2545945`](https://app.codecov.io/gh/apache/grails-core/commit/254594535f923dba2d8952c81755552bdccad875?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69ea462`](https://app.codecov.io/gh/apache/grails-core/commit/69ea4627814f837dd02b7d7246b08622a44947a0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16340?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ails/compiler/web/ControllerActionTransformer.java](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-controllers%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fcompiler%2Fweb%2FControllerActionTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnRyb2xsZXJzL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2NvbXBpbGVyL3dlYi9Db250cm9sbGVyQWN0aW9uVHJhbnNmb3JtZXIuamF2YQ==) | 14.7059% | [27 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/grails/datastore/gorm/finders/DynamicFinder.java](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Ffinders%2FDynamicFinder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vZmluZGVycy9EeW5hbWljRmluZGVyLmphdmE=) | 74.1936% | [10 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../apache/grails/common/reflect/ReflectionUtils.java](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Fgrails%2Fcommon%2Freflect%2FReflectionUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbW1vbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2FwYWNoZS9ncmFpbHMvY29tbW9uL3JlZmxlY3QvUmVmbGVjdGlvblV0aWxzLmphdmE=) | 71.7949% | [6 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...orm/hibernate/query/GrailsHibernateQueryUtils.java](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-data-hibernate5%2Fcore%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Form%2Fhibernate%2Fquery%2FGrailsHibernateQueryUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGEtaGliZXJuYXRlNS9jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL29ybS9oaWJlcm5hdGUvcXVlcnkvR3JhaWxzSGliZXJuYXRlUXVlcnlVdGlscy5qYXZh) | 56.2500% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...b/controllers/api/ControllersDomainBindingApi.java](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-controllers%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fcontrollers%2Fapi%2FControllersDomainBindingApi.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnRyb2xsZXJzL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3BsdWdpbnMvd2ViL2NvbnRyb2xsZXJzL2FwaS9Db250cm9sbGVyc0RvbWFpbkJpbmRpbmdBcGkuamF2YQ==) | 75.0000% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...in/groovy/org/grails/io/support/SpringIOUtils.java](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-gradle%2Fmodel%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fio%2Fsupport%2FSpringIOUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdyYWRsZS9tb2RlbC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9pby9zdXBwb3J0L1NwcmluZ0lPVXRpbHMuamF2YQ==) | 87.0968% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../GrailsInterceptorHandlerInterceptorAdapter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-interceptors%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Finterceptors%2FGrailsInterceptorHandlerInterceptorAdapter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWludGVyY2VwdG9ycy9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9pbnRlcmNlcHRvcnMvR3JhaWxzSW50ZXJjZXB0b3JIYW5kbGVySW50ZXJjZXB0b3JBZGFwdGVyLmdyb292eQ==) | 80.9524% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...sting/AbstractGrailsMockHttpServletResponse.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-test-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Ftesting%2FAbstractGrailsMockHttpServletResponse.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXRlc3QtY29yZS9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3Rlc3RpbmcvQWJzdHJhY3RHcmFpbHNNb2NrSHR0cFNlcnZsZXRSZXNwb25zZS5ncm9vdnk=) | 0.0000% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ers/marshaller/json/GenericJavaBeanMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FGenericJavaBeanMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL0dlbmVyaWNKYXZhQmVhbk1hcnNoYWxsZXIuamF2YQ==) | 50.0000% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ters/marshaller/xml/GenericJavaBeanMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fxml%2FGenericJavaBeanMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci94bWwvR2VuZXJpY0phdmFCZWFuTWFyc2hhbGxlci5qYXZh) | 57.1429% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [15 more](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## 8.1.x #16340 +/- ## ================================================== + Coverage 55.8236% 56.1540% +0.3304% - Complexity 21437 21778 +341 ================================================== Files 2146 2154 +8 Lines 102616 102981 +365 Branches 18160 18252 +92 ================================================== + Hits 57284 57828 +544 + Misses 37382 37039 -343 - Partials 7950 8114 +164 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16340?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...s/web/async/AsyncWebRequestPromiseDecorator.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fasync%2FAsyncWebRequestPromiseDecorator.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hc3luYy9Bc3luY1dlYlJlcXVlc3RQcm9taXNlRGVjb3JhdG9yLmdyb292eQ==) | `75.6098% <100.0000%> (ø)` | | | [.../src/main/groovy/grails/artefact/Controller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-controllers%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fartefact%2FController.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnRyb2xsZXJzL3NyYy9tYWluL2dyb292eS9ncmFpbHMvYXJ0ZWZhY3QvQ29udHJvbGxlci5ncm9vdnk=) | `0.0000% <ø> (ø)` | | | [...act/controller/support/AllowedMethodsHelper.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-controllers%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fartefact%2Fcontroller%2Fsupport%2FAllowedMethodsHelper.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnRyb2xsZXJzL3NyYy9tYWluL2dyb292eS9ncmFpbHMvYXJ0ZWZhY3QvY29udHJvbGxlci9zdXBwb3J0L0FsbG93ZWRNZXRob2RzSGVscGVyLmdyb292eQ==) | `70.0000% <100.0000%> (ø)` | | | [...efact/controller/support/ResponseRedirector.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-controllers%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fartefact%2Fcontroller%2Fsupport%2FResponseRedirector.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnRyb2xsZXJzL3NyYy9tYWluL2dyb292eS9ncmFpbHMvYXJ0ZWZhY3QvY29udHJvbGxlci9zdXBwb3J0L1Jlc3BvbnNlUmVkaXJlY3Rvci5ncm9vdnk=) | `0.0000% <ø> (ø)` | | | [...GrailsHiddenHttpMethodFilterAutoConfiguration.java](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-controllers%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fcontrollers%2FGrailsHiddenHttpMethodFilterAutoConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnRyb2xsZXJzL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3BsdWdpbnMvd2ViL2NvbnRyb2xsZXJzL0dyYWlsc0hpZGRlbkh0dHBNZXRob2RGaWx0ZXJBdXRvQ29uZmlndXJhdGlvbi5qYXZh) | `100.0000% <100.0000%> (ø)` | | | [...core/src/main/groovy/grails/config/Settings.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-core%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fconfig%2FSettings.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9jb25maWcvU2V0dGluZ3MuZ3Jvb3Z5) | `100.0000% <ø> (ø)` | | | [...vy/org/apache/grails/core/plugins/PluginUtils.java](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Fgrails%2Fcore%2Fplugins%2FPluginUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9hcGFjaGUvZ3JhaWxzL2NvcmUvcGx1Z2lucy9QbHVnaW5VdGlscy5qYXZh) | `73.1579% <ø> (ø)` | | | [.../groovy/grails/databinding/SimpleDataBinder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-databinding-core%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fdatabinding%2FSimpleDataBinder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFiaW5kaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9kYXRhYmluZGluZy9TaW1wbGVEYXRhQmluZGVyLmdyb292eQ==) | `74.3210% <100.0000%> (-0.1840%)` | :arrow_down: | | [...ovy/org/grails/datastore/gorm/GormStaticApi.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2FGormStaticApi.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vR29ybVN0YXRpY0FwaS5ncm9vdnk=) | `76.1290% <100.0000%> (-0.2464%)` | :arrow_down: | | [...ails/data/testing/tck/tests/ListOrderBySpec.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree&filepath=grails-datamapping-tck%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Fgrails%2Fdata%2Ftesting%2Ftck%2Ftests%2FListOrderBySpec.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLXRjay9zcmMvbWFpbi9ncm9vdnkvb3JnL2FwYWNoZS9ncmFpbHMvZGF0YS90ZXN0aW5nL3Rjay90ZXN0cy9MaXN0T3JkZXJCeVNwZWMuZ3Jvb3Z5) | `100.0000% <100.0000%> (ø)` | | | ... and [38 more](https://app.codecov.io/gh/apache/grails-core/pull/16340?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [108 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16340/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
