codeconsole commented on PR #16184: URL: https://github.com/apache/grails-core/pull/16184#issuecomment-5684703057
@matrei @jdaugherty Addressed in bf09ab4b6ceda93eea7343277a08f53249ae5af6. The upgrade note now distinguishes Grails 7 from the earlier Grails 8 milestones: a custom `@SpringBootTest(classes = SomeConfig)` without the application class did not receive the Grails plugin lifecycle in Grails 7. It also explains automatic application-class discovery, the existing Hibernate startup limitation, and how to apply the startup defaults using `useMainMethod = ALWAYS` or the two Spring Boot properties. Also addressed the non-blocking nit by replacing the duplicate servlet-context helper with Spring's inherited `getServletContext()`. Expanded coverage for JSP paths with and without a leading slash, missing views, disabled JSP fallback, and JSP/error-page rendering under a non-root context path. Validation: all 30 module tests and 16 standalone example tests passed, as did the module's `codeStyle` task and the guide build. The full repository pre-commit check did not complete: the first run's Gradle daemon exited, and the reduced-parallelism retry was canceled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
