codeconsole commented on PR #16208: URL: https://github.com/apache/grails-core/pull/16208#issuecomment-5753210892
Addressed round 2. `8.0.x` is merged in (`63776a4f42`, conflict-free as you found, now 261 commits rather than 51). **1. Logger category.** Confirmed after the merge: `MongoDatastore` carries its own `LOG` at line 160, so the per-index `DEBUG` line, the summary and the shutdown line all move to `org.grails.datastore.mapping.mongo`. `queryIndexes.adoc` and the PR description now say that. The specs stay on the shared `org.grails.datastore.mapping` parent, which covers either logger. (`4710351bbe`) **2. Supplied-client scope.** Your reading of `buildConnectionSourceSettings()` is right, and each consequence checks out: `GormEnhancer` takes `failOnError` and `markDirty` straight from the settings, and `AbstractConnectionSourceFactory.setTenantResolver` is `@Autowired(required = false)` on a factory this path never constructs as a bean, so `NoTenantResolver` is what a `DISCRIMINATOR` mode gets and it throws on every tenant-scoped operation. A sibling section, "Configuration Is Now Applied to an Externally-Supplied Client", now sits beside the client-lifecycle note in `upgradeNotes.adoc`: `failOnError`, `default.mapping`, `default.constraints`, `autoFlush`, `markDirty`, `flushMode` and multi-tenancy, with the `tenantResolverClass` step spelled out as the only way to supply a resolver here. The release-note bullet is cut down to a pointer. (`4ebb343fce`) **3. Snapshot in `close()`.** Taken. (`5e3403efe5`) **4. Codecov.** Left alone, as you suggested. On targeting: that is @jdaugherty's call. The two index-build settings are additive and can move to 8.1 as he asked. If they do, the supplied-client fix should be split out and stay in 8.0 for the reason you gave — it changes what existing configuration means at runtime, and 8.0.0 already carries upgrade notes for this audience. Say the word and I will split it. **Verification:** `:grails-data-mongodb-core:cleanTest :grails-data-mongodb-core:check --no-build-cache --continue` — 774 tests, 0 failures, 0 errors, 45 skipped across 218 result files; `checkstyleMain` and `codenarcMain` clean. `:grails-data-mongodb-docs:asciidoctor -x aggregateGroovydoc` successful, with the `<<upgradeNotes>>` xref resolving in the rendered output and the same pre-existing `possible invalid reference` INFO lines. Root `aggregateViolations` clean on all four reports, `rat` clean. Unrelated, in case it bites you locally: `rat` failed for me until I deleted `grails-data-neo4j/grails-plugin/data/`, an embedded Neo4j store a test leaves behind. It is untracked and not in `.gitignore`, so any run of the Neo4j tests followed by `rat` reports two unapproved licenses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
