matrei commented on PR #16357: URL: https://github.com/apache/grails-core/pull/16357#issuecomment-5761155821
Thanks for the review, @sbglasius. **Silent drop fallback** – agreed, e11f509f06 makes it a `log.warn` that names the collection and the cause before dropping it. One caveat: this module runs its tests with `org.slf4j:slf4j-nop`, so the warning (like the existing `Could not clear ...` one in `destroy()`) only becomes visible once a real SLF4J binding is swapped in, which is what one would do when chasing a reappearance of the fd churn. I kept it a logger call rather than printing to stderr, since the view feature in `GrailsDataMongoTckManagerSpec` takes this path on every run. **`system.views`** – yes, that is the intended split: `system.*` is skipped, the view itself fails `deleteMany` and goes through the drop path, and the drop removes its `system.views` entry, which is what `cleanup drops collections that do not support deletes` asserts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
