jdaugherty commented on issue #14915: URL: https://github.com/apache/grails-core/issues/14915#issuecomment-5816164025
I revisited this and confirmed that the original change was not needed: - It fixed a problem that did not exist. The plain resources.groovy DSL never went through Spring XML. It registered programmatic bean definitions all along. The XML reader was constructed at startup and then only used by xmlns and .xml imports. - It did not remove any XML dependency. The same four Spring XML classes are still required for xmlns and importBeans. They just moved into a lazily built holder. If Spring ever drops them, Grails is in the same position either way, and none of them are deprecated in Spring 7.0.9. - It did not do what the issue asks for. Issue 14915 wants the DSL deprecated and re-implemented on BeanRegistrar. The PR did not touch that. The actual bean dsl enhancements & moving to `@Configuration` is the real fix to this ticket. We've moved the majority of Grails to use these internally and will be eventually removing `resources.groovy`. There's no further change required for this so closing this and moving it to RC1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
