The GitHub Actions job "CI" on grails-gradle-publish.git/chore/gradle-9.8 has 
failed.
Run started by GitHub user jdaugherty (triggered by jdaugherty).

Head commit for run:
161dc93cf2ec282fa8cdc7541d1bd2d0175d0bed / James Daugherty 
<[email protected]>
Read parent project properties explicitly instead of failing on them

Gradle 10 removes the implicit lookup of parent project properties that
Project.findProperty performs, so the plugin must stop relying on it. PR #39
replaced it with a lookup limited to the project itself and its Gradle
properties, failing when a publish type or Nexus URL was only set on a
parent. That breaks the grails-core layout: its root build script applies the
plugin to the subprojects before their own scripts set `projectVersion` on
them, so at that point only the root's `ext` holds it, and grails-gradle's
publishAllToMavenLocal failed with "unspecified version".

Reading a parent's `ext` explicitly is not deprecated (verified against
Gradle 9.8.0 with --warning-mode=all), only the implicit lookup is. The
plugin now reads the project's `ext`, then Gradle properties, then parent
projects' `ext`, reporting a parent lookup so builds can move the property
where Isolated Projects can read it (warn, or info for `projectVersion` and
`githubSlug`, which every project of a build inherits). Parents are not read
when Isolated Projects is active. A property, wherever it comes from, keeps
taking precedence over its environment variable, as on 1.0.x.

The tests that expected the failures now expect the value to be used with
the warning, and the fixture puts a non-default publish type on the parent
so the effect is observable.

Report URL: 
https://github.com/apache/grails-gradle-publish/actions/runs/36368629428

With regards,
GitHub Actions via GitBox

Reply via email to