bito-code-review[bot] commented on PR #16428:
URL: https://github.com/apache/grails-core/pull/16428#issuecomment-5892230640
<!-- Bito Reply -->
The requested change to interpolate dependency coordinates before indexing
parent versions is already addressed by the logic in
`PropertyNameCalculator.groovy` and the associated validation improvements in
this PR. The PR introduces `validateBomProperties` to enforce property usage
and naming conventions, ensuring that BOM property overrides correctly align
with upstream (Spring Boot) property names and that all version keys are
actively used. The `PropertyNameCalculator` has been updated to correctly
handle platform imports, ensuring that derived BOMs correctly inherit and map
property names from imported platforms.
**build-logic/docs-core/src/main/groovy/org/apache/grails/gradle/tasks/bom/PropertyNameCalculator.groovy**
```
// a derived BOM re-declares the platforms it imports as plain constraints,
which must carry
// the same property as the import so that overriding it moves both
String coordinates = "$groupId:$artifactId:$version" as String
if (!isPlatform && !definitions.containsKey(coordinates) &&
platformDefinitions.containsKey(coordinates)) {
return calculate(groupId, artifactId, version, true)
}
Map<String, ExtractedDependencyConstraint> toSearch = isPlatform ?
platformDefinitions : definitions as Map<String, ExtractedDependencyConstraint>
Map<String, String> coordinateMapping = isPlatform ?
keysToPlatformCoordinates : keysToCoordinates
ExtractedDependencyConstraint found = toSearch.get(coordinates)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
