jdaugherty commented on PR #16143: URL: https://github.com/apache/grails-core/pull/16143#issuecomment-5914557326
I rebased this onto current `8.1.x` (head is now 4e535bf12e) and pushed, so it merges cleanly again. Notes on what changed and why: **Rebase** - Both conflicts were in the reactive `DetachedCriteria` and its spec. `8.1.x` already carries the `DELEGATE_FIRST` closure signatures, the `QueryableCriteria` subquery adapter and the `prepareQuery` fetch-strategy de-duplication that this PR originally introduced, so I kept the `8.1.x` side and applied only what the PR still adds: the `RxQuery<T>` generics. The `(Class<Observable<T>>) (Class) targetClass` double cast is gone because the `8.1.x` code compiles without it. - The PR description now reflects the post-rebase scope. **Review fix, pushed as a separate commit** - The `AbstractDetachedCriteriaSpec` features for `createAlias`, `propertyMissing`, `methodMissing` and `getPersistentClass` faked a GORM entity by writing Spock mocks into the private `persistentEntity` and `dynamicFinders` fields, and several features asserted on `lazyQuery`, `connectionName` and `associationCriteriaMap` directly. That bypasses the public surface, which our test rules require going through. Those features now run against two `@Entity` fixtures registered with a `SimpleMapDatastore`, the same pattern the rest of this module uses. As a result the spec now also verifies things the mocks could not: a dynamic finder called on the criteria is combined with the detached criteria, a nested association closure filters the executed query, `withConnection` really executes against the named connection, and `buildLazy` applies its closure exactly once. The unmodifiable-view check now covers `getJoinTypes` as well. Verified locally on the rebased branch: `:grails-datamapping-core:test` (1564 tests), `:grails-datamapping-rx:test` (495 tests) and `codeStyle` for both modules are all green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
