jdaugherty commented on PR #16466:
URL: https://github.com/apache/grails-core/pull/16466#issuecomment-5952931672
@matrei thanks for the review. All four suggestions are applied in
7ea637dace.
1. **Paragraph order:** the unit-test paragraph now follows the wildcard
example and says domains mocked with `DataTest` or `DomainUnitTest` use the
same settings as the running application, so it covers both forms.
2. **`doWithConfig` form:** the upgrade guide and `RequiredByDefaultSpec`
now use `Closure doWithConfig() {{ config -> ... }}`, matching
`unitTesting.adoc`.
3. **`@Override`:** added to `doWithConfig()` in both places.
4. **`setupSpec()`:** both specs now mock only `NullableTestAuthor` in
`setupSpec()` instead of overriding `getDomainClassesToMock()`.
`:grails-testing-support-datamapping:test` and `codeStyle` pass. With only
`DataTestSetupSpecInterceptor` reverted, the domain feature in
`RequiredByDefaultSpec` still fails, so the reshaped specs still catch the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
