The GitHub Actions job "JMH Benchmark Comparison" on grails-core.git/fix/15933-override-to-from-addresses has failed. Run started by GitHub user ruthst00 (triggered by ruthst00).
Head commit for run: 2af4f3d9782be2a765c55459aaf06e1162f5a9ee / ruthes00 <[email protected]> `upgrading80x.adoc`, `SKILL.md`, and `mailConfiguration.adoc` have been updated to accurately reflect the implementation in `MailMessageBuilder.groovy` and `MailConfigurationProperties`. The key changes from the original text: 1. Removed the misleading "No action is required" paragraph — the original claimed `overrideAddress` works "exactly as before," which was confusing given the new fallback logic being described right above it. 2. Clarified the fallback behavior — each specific property (`overrideToAddress`, `overrideFromAddress`) falls back to `overrideAddress` when not set. 3. Expanded the bullet descriptions to match the actual implementation: - `overrideToAddress` covers to, cc, and bcc (not just "recipient addresses"), and also acts as the default `to` when none is set in the closure. - `overrideFromAddress` overrides the sender including explicit `from` calls, and also acts as the **default `from`** when none is set. 4. Updated the comment in the `overrideToAddress` YAML example to say "redirect all recipients (to, cc, bcc) only" for clarity. 5. Mentioned that `overrideAddress` now also replaces a `from` set explicitly in sendMail. An application that wants to keep its real sender should use `overrideToAddress` in place of `overrideAddress`. Dropped "backward-compatibility" from test "Test that overrideAddress overrides the explicit from address" `mailTesting.adoc` reverted back to say "The disadvantage is that it requires a real SMTP server and makes it difficult to test address determination logic.". Also updated language to reflect logic changes. Removed redundant test "Test that overrideAddress overrides both to and from" Report URL: https://github.com/apache/grails-core/actions/runs/36989796462 With regards, GitHub Actions via GitBox
