jdaugherty commented on PR #16478: URL: https://github.com/apache/grails-core/pull/16478#issuecomment-5955850243
Thanks @matrei. Finding 1 is fixed in c8d4040e4d, which landed on `8.0.x` with this PR in 6b8d71c7c7. `CountFinder.applyCriteriaAndCount` no longer calls `configureQueryWithArguments`, so `countBy*` ignores a trailing argument map again, as `CountByFinder` did. The `countBy*Or*` change for #15789 doesn't depend on it. - `FindByMethodSpec` has a new TCK feature that asserts `countByFirstName` and `countByFirstNameOrLastName` return the unpaged count with `[max: 2, offset: 3]`, `[sort: 'age', order: 'desc']`, both combined, and `[sort: 'nope']`. It passes on the simple datastore, Hibernate 5, Hibernate 7, MongoDB and Neo4j. - `CountFinderSpec` pins it at unit level: with any of those maps, or `[cache: true, lock: true]`, nothing reaches `max`, `offset`, `order`, `cache` or `lock` on the query. With the `configureQueryWithArguments` call put back, all five `CountFinderSpec` rows fail, and every TCK row fails on the simple datastore, Hibernate 5, or both. `upgrading80x.adoc` conflicted with #16452, which took section 82 shortly before this landed, so the finder section is now 83. The `8.1.x` side goes in with the merge-up: `RxCountFinder` will call `configureQueryWithArguments` itself so RxGORM keeps applying the map, and section 83 will keep the RxGORM sentence from your second point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
